ReactiveX / ReactiveX/RxJava

4.x: Separate `TestHelper.race` uses so they can run `@Isolated`

Open
#8,075 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

4.x PR welcome Test Test-Failures
Dominant language
Java
Stars
48.2k
Forks
7.6k
Avg merge
39m
Merged PRs (30d)
11

Description

There are no failures but the race tests are there to provoke failures. Them not failing when run parallel might just indicate the failure condition wasn't triggered due to interleaving.

Separating them out and running them JUnit 6 @Isolated can restore faith.

Also double check for any manual racing tests that haven't been converted to TestHelper.race before.

PR Welcome.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing TestHelper.race uses and the race tests that rely on interleaving to expose failures. Review how JUnit 6 @Isolated applies to tests, then check for manual racing tests that have not been converted. Done means the relevant race tests are separated, isolated, and still exercise their intended failure conditions.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.