ReactionMechanismGenerator / ReactionMechanismGenerator/T3
Cantera adapters expect T /P to be scalars and crash if they are lists
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 14
- Forks
- 7
- Avg merge
- 22h 36m
- Merged PRs (30d)
- 22
Description
RMG reactors accept T / P both as floats and as lists, but the Cantera adapters send these values w/o modification to Cantera as a (T0, P0, X0) tuple. If T / P are indeed lists, T3/Cantera crash.
Need to fix the adapters to allow T / P in a reactor to be a list.
Would we like to take the average value of the list? Or iterate through it?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Locate the Cantera adapter code that builds the (T0, P0, X0) tuple, then clarify with maintainers whether list-valued T/P should be averaged or iterated. Done means list-valued reactor inputs no longer crash and the chosen behavior is covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100