ReactionMechanismGenerator / ReactionMechanismGenerator/T3

make test: RuntimeWarning: divide by zero

Open
#65 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Type: Bug
Dominant language
Python
Stars
14
Forks
7
Avg merge
22h 36m
Merged PRs (30d)
22

Description

Describe the bug
Clean install with conda / environment.yml from clone of current git repo followed by running make test produces warning:

tests/test_functional.py::test_no_t3_no_qm
  $HOME/Code/RMG-Py/rmgpy/rmg/main.py:822: RuntimeWarning: divide by zero encountered in true_divide
    conditions=self.rmg_memories[index].get_cond()

How to reproduce
make test

Expected behavior
No errors or warnings

Additional context
$HOME substituted into raw output, above, not printed as such in terminal
Miniconda 3 on Fedora Rawhide

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Run make test and inspect tests/test_functional.py::test_no_t3_no_qm together with the warning location in rmgpy/rmg/main.py:822. Trace the divide-by-zero condition and confirm that the test suite completes without errors or warnings.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.