ReactionMechanismGenerator / ReactionMechanismGenerator/RMG-database

Thermo groups regression test

Open
#558 0 comments 0 reactions 1 assignee View on GitHub

@hwpang is already working on this.

Since Jan 12, 2022.

Topic: Thermo Type: Risk of Error
Dominant language
Python
Stars
127
Forks
160
Avg merge
6d 2h
Merged PRs (30d)
2

Description

Adding and/or modifying thermo groups in the database can have unintended consequences for molecules outside a training or test set. This problem often arises with "supergroups" (groups that include neighborhood dimensions > 1) and "double counting" a particular chemical moiety included in supergroups. Making an RMG regression test that compares RMG thermo library values vs GAV estimates (and flags molecules where GAV predictions are worse with PR compared to library values) could help identity these problems in PRs.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.