ReactionMechanismGenerator / ReactionMechanismGenerator/RMG-database

Duplicate surface reactions with different kinetics

Open
#432 0 comments 0 reactions 2 assignees View on GitHub

@davidfarinajr is already working on this.

Since Jul 9, 2020.

Topic: Catalysis Topic: Kinetics
Dominant language
Python
Stars
127
Forks
160
Avg merge
6d 2h
Merged PRs (30d)
2

Description

Found two pairs of duplicate reactions for surface_abstraction_vdW family that matched different nodes in the family tree, and therefore, had different kinetics (see screenshots below). I used experimental branches to generate this model:
RMG-Py: https://github.com/davidfarinajr/RMG-Py/tree/HAN_surface_equil
RMG-database: https://github.com/davidfarinajr/RMG-database/tree/HAN_training_reactions

Not sure if I created this problem with my changes on those branches, or if it is a problem related to https://github.com/ReactionMechanismGenerator/RMG-database/pull/385

Screen Shot 2020-07-09 at 10 45 13 AM Screen Shot 2020-07-09 at 12 16 48 PM

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.