ReactionMechanismGenerator / ReactionMechanismGenerator/RMG-database
Suggestions on kinetic libraries
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 127
- Forks
- 160
- Avg merge
- 6d 2h
- Merged PRs (30d)
- 2
Description
- C3, Fulvene_H, C10H11, vinylCPO_H and napthalene_H have the same descriptions. Maybe Either combine them into one library or tailored descriptions and put them under a folder(like Dooley)
- 2009_Sharma_C5H5_CH3_highP and c-C5H5_CH3_sharma (Pdep). Maybe put them under a folder and distinguish as high P and Pdep.
- Glarborg libraries and Methylformate have no descriptions to indicate the source, level of theory used or so on...
- Mebel_C6H5_C2H2 (Pdep) and /First_to_Second_Aromatic_Ring/2017_Mebel_C6H5_C2H2_highP (highP) are the same except pressure dependency. Maybe distinguish them in the description and put Mebel_C6H5_C2H2 in the /First_to_Second_Aromatic_Ring/
- Mebel_Napthyl maybe also add to the /First_to_Second_Aromatic_Ring/.
- Put all the Nitrogen_* together into /Nitrogen?
The organization of the current reaction libraries is a little bit messy, I think we need to clean it up for more user-friendliness. A rough idea is probably we can use the following structure::
$----- Fitted Mechanism
(contain things like GRI, CurrenPentane which are usually 'complete mechanisms and fitted to achieve better performance)
$|
$ --- Accurate Submechanisms
(which contain values we are sure from Ab initio Calculation and Experiments
$ |
$ --- Submechanisms groups
(something like First_to_Second_Aromatic_Rings)
$ |
$ --- First_to_Second_Aromatic_Rings
$ | |
$ | --- Mebel_C6H5_C2H2
$ | |
$ | --- High P
$ | |
$ | --- Pdep
.................
Besides, it becomes vaguer to me that how we should use kinetic libraries. We have a tree estimators and a lot of reactions in the kinetic libraries have already added as training reactions so that even if we don't import the kinetic library during the job, we might still use the parameters. Maybe just used as seed mechanisms?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the current kinetic-library tree, including the named libraries and folders such as First_to_Second_Aromatic_Ring and Nitrogen. Then determine how library organization, descriptions, pressure distinctions, and seed-mechanism usage are represented. Done requires an agreed structure and explicit scope, which this issue does not yet define.
Written by the indexing model from the issue text.
Assessment
- Domain
- database
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100