ReactionMechanismGenerator / ReactionMechanismGenerator/ARC

Relocate ts_adapters_by_rmg_family

Open
#569 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Good first issue Type: Feature
Dominant language
Python
Stars
51
Forks
25
Avg merge
4d 5h
Merged PRs (30d)
15

Description

I think that ts_adapters_by_rmg_family from adapters/common.py should be relocated to data as a YAML file

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in arc/job/adapters/common.py at ts_adapters_by_rmg_family, then search the repository for references to it and inspect the data directory's existing file conventions. Relocate the mapping into a YAML file while keeping its consumers working, and run the relevant adapter or repository tests if available.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, yaml
Domain
data
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.