ReactionMechanismGenerator / ReactionMechanismGenerator/ARC
Put xyz data for testing at a centralized location
Open
Nobody has claimed this yet.
Type: Code Organization
Type: Feature
Type: Testing
- Dominant language
- Python
- Stars
- 51
- Forks
- 25
- Avg merge
- 4d 5h
- Merged PRs (30d)
- 15
Description
There are duplicates of xyz/zmat/dmat data in ARC's tests (e.g., many definitions for the same xyz of CH4).
It could be neater to have the data at a centralized and organized file (YAML?) that all tests can access.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in ARC's tests by locating the repeated xyz, zmat, and dmat definitions, including the duplicated CH4 data. Decide how a centralized organized data file can be shared by all tests, then verify the tests use the shared data without duplicate definitions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100