ReactionMechanismGenerator / ReactionMechanismGenerator/ARC

Wrong model chemistry determination when not explicitly specifying the sp level

Open
#350 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Good first issue Type: Bug
Dominant language
Python
Stars
51
Forks
25
Avg merge
4d 5h
Merged PRs (30d)
15

Description

When the sp level is equal to the opt (and freq) level, e.g., when simply setting level_of_theory: B3LYP/CBSB7, it results in a weird model_chemistry:
Using ///b3lyp/cbsb7 as a model chemistry in Arkane
(it should have been sp_method/sp_basis//b3lyp/cbsb7).
The correct behavior should be in this case b3lyp/cbsb7//b3lyp/cbsb7

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Search for the handling of level_of_theory and model_chemistry, then reproduce the B3LYP/CBSB7 case; done means equal opt and freq levels produce b3lyp/cbsb7//b3lyp/cbsb7 rather than ///b3lyp/cbsb7.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.