Allow DCE results to be included in the reports
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- javascript, node.js
- Domain
- testing-qa, tooling
Research direction
Start by tracing the JSON Reporter, DCE checks, and the onCompleteBenchmark hook mentioned in the issue, then inspect how Workers invoke the same flow. Done means DCE warnings appear in parseable benchmark reports and DCE checks also work with Workers; no specific files or tests are named.
Written by the indexing model from the issue text.
Description
In Faceoff I serialize the test run output to a file using the JSON Reporter. Since the DCE checks are being handled out of band of the benchmark results, there is no good way for the reporters to add the warnings into the parseable output from a benchmark run, which would be useful information.
It would also be good if DCE checks would function with Workers, and I think these two might be the same problem.
I'm not sure how to fix this. The obvious solution would be to annotate the results rather than collecting the warnings within the plugin, but onCompleteBenchmark, despite taking 'result' as the first parameter, doesn't actually receive the result but an array of values, and the function is treated as a void method so cooking the input is tricky at best.
Do you have any suggestions or ideas on how else this could be achieved?
- Dominant language
- JavaScript
- Stars
- 193
- Forks
- 19
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from RafaelGSS/bench-node
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 45/100
RafaelGSS/bench-node#168 · 1 comment ·
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 55/100
RafaelGSS/bench-node#167 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
RafaelGSS/bench-node#138 · 4 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
RafaelGSS/bench-node#130 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
RafaelGSS/bench-node#121 · 3 comments ·
All issues in RafaelGSS/bench-node
Similar issues
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github/gh-aw-firewall#8816 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
optimization optimization:agents-md-curator
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
githubnext/gh-aw-cao#13143 ·
-
status: needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100