RadioAstronomySoftwareGroup / RadioAstronomySoftwareGroup/pyuvdata
Maybe make UVBeam tests more modular
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 102
- Forks
- 35
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 14
Description
Some of the tests for the UVBeam object are relatively long, and test multiple aspects. Some of this is for performance reasons, to save duplicated work getting the object to be in the right state for a given test. However, we should still try to be as modular as possible, so that a failed test is more indicative of what exactly went wrong and individual tests are easier to follow. In cases where it doesn't make sense to break tests up, we should add comments explaining the motivation behind keeping things as they are.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the UVBeam tests and reviewing which tests cover multiple aspects or repeat setup work. Separate cases where practical, and add comments explaining any tests that remain combined for performance; the UVBeam test suite should make failures more specific and individual tests easier to follow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100