RadioAstronomySoftwareGroup / RadioAstronomySoftwareGroup/pyuvdata
Handle 2 pi azimuth wrap arounds in `uvbeam._interp_az_za_rect_spline`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 102
- Forks
- 35
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 14
Description
The function for converting enu to az_za in vis_cpu (a standard HERA simulator method)
which is used to produce azimuths to be interpolated by uvbeam
outputs azimuths between -pi and pi.
Many uvbeam objects can be expected to only have positive azimuths (for example, cst beams only run from 0 to 2pi) and this raises the error in uvbeam at
This could be avoided if uvbeam recognized negative azimuth values as being identical to positive azimuth values (mod 2 pi).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading uvbeam._interp_az_za_rect_spline and the referenced pyuvdata/uvbeam/uvbeam.py location around line 1387, then review the linked vis_cpu conversions.py azimuth conversion. Done means negative azimuths are accepted as equivalent to positive values modulo 2 pi instead of raising the current error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100