RT-Thread / RT-Thread/rt-thread

DFS timeout issue

Open
#5,386 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
12.2k
Forks
5.4k
Avg merge
4d 12h
Merged PRs (30d)
40

Description

the poll_do treats non-zero return as timeout, but the function poll_wait_timeout does the opposite.

        if (num || istimeout)
            break;

        if (poll_wait_timeout(pt, msec))
            istimeout = 1;
    }
static int poll_wait_timeout(struct rt_poll_table *pt, int msec)
{
 ......

    ret = !pt->triggered;
    rt_hw_interrupt_enable(level);

    return ret;
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the DFS path in poll_do and the poll_wait_timeout implementation shown in the issue. Trace how their return values set istimeout, then verify that the timeout convention is consistent and DFS no longer reports a timeout incorrectly.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
embedded-iot, operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.