RT-Thread / RT-Thread/rt-thread
__rt_ffs 返回值为 0 的疑问
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 12.2k
- Forks
- 5.4k
- Avg merge
- 4d 12h
- Merged PRs (30d)
- 40
Description
曾经官网上有人提了个问题 调度器这块是不是有漏洞
他说,__rt_ffs 函数可以返回 0 ,但是返回值是 0 的时候,所有调用这个函数的地方都把返回值减了 1,这样所有使用的地方当数组索引就会出现 -1 索引。
当时,我反问他,__rt_ffs 函数会返回 0 吗,或者说输入参数 rt_thread_ready_priority_group 会是 0 吗?个人理解,因为 idle 线程的存在 rt_thread_ready_priority_group 总是有值的,不会出现 0 的情况。
而且,实际情况也确实是,不允许出现 0,出现 0 意味着肯定有无法修复的错误出现了,这种情况。 if (value == 0) return value; 判断再多么严谨也没实际意义。
今天,在一款 arm9 芯片上测试 #5063 的时候发现了两个问题:
- keil 里编译的汇编代码,求模运算竟然是
EB00444F BL __aeabi_uidiv内置函数调用,这样一来,好像汇编代码也没少,反而更多了。 - 所有的
__rt_ffs实现都向__builtin_ffs实现看齐,特意进行加 1 ,然后在调用的地方再减去 1。这个不能向应用看齐?return __builtin_ffs()-1;其它的__rt_ffs返回值从 0 到 31。如果觉得函数名可能会出现歧义,改个名字。
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the __rt_ffs implementations and their call sites, especially uses of rt_thread_ready_priority_group, then compare them with __builtin_ffs. Reproduce the ARM9/Keil case associated with #5063 and inspect the __aeabi_uidiv-generated modulo code. Done means the expected return-value convention and the impact of the generated assembly are established clearly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100