RT-Thread / RT-Thread/rt-thread

Missing address indirection in usb device

Open
#3,639 5 comments 0 reactions 1 assignee View on GitHub

@lymzzyh is already working on this.

Since May 31, 2020.

Status: waiting for test
Dominant language
C
Stars
12.2k
Forks
5.4k
Avg merge
4d 12h
Merged PRs (30d)
40

Description

Hi,

In components/drivers/usb/usbdevice/core/core.c in _ep0_out_notify around line 888 the line that currently reads;

size = dcd_ep_read(device->dcd, EP0_OUT_ADDR, ep0->request.buffer);

should be updated to read;

size = dcd_ep_read(device->dcd, EP0_OUT_ADDR, &ep0->request.buffer);

...otherwise bad things happen, but not very often.

DAVE

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.