RT-Thread / RT-Thread/rt-thread
[Bug] riscv64架构下的arch_signal_quit 的实现存在风险
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 12.2k
- Forks
- 5.4k
- Avg merge
- 4d 12h
- Merged PRs (30d)
- 40
Description
RT-Thread Version
ece19e9
Hardware Type/Architectures
riscv64 qemu
Develop Toolchain
GCC
Describe the bug
components/lwp/arch/risc-v/rv64/lwp_gcc.S 中的arch_signal_quit中将内核栈中的地址保存到用户栈中,之后又从用户栈中的保存值恢复sp,在多核环境下,如果另外一个核心运行的其他线程(属于同一进程)通过修改当前线程用户栈里保存的内核栈地址,可能导致内核崩溃,需要考虑该函数更安全的实现方案。
arch_signal_quit:
LOAD a0, FRAME_OFF_SP(sp)
addi a1, sp, CTX_REG_NR * REGBYTES
call arch_signal_ucontext_restore
/* reset kernel sp to the stack */
addi sp, sp, CTX_REG_NR * REGBYTES
STORE sp, FRAME_OFF_SP(a0)
/* return value is user sp */
mv sp, a0
/* restore user sp before enter trap */
addi a0, sp, CTX_REG_NR * REGBYTES
csrw sscratch, a0
RESTORE_ALL
SAVE_ALL
j arch_ret_to_user
Other additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with components/lwp/arch/risc-v/rv64/lwp_gcc.S and trace arch_signal_quit together with arch_signal_ucontext_restore, RESTORE_ALL, and arch_ret_to_user. Reproduce or inspect the riscv64 qemu path to understand how the saved kernel-stack address can be changed across cores. Done means a safer implementation is defined and verified without allowing that user-stack value to cause a kernel crash.
Written by the indexing model from the issue text.
Assessment
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100