ROCm / ROCm/rocm-cli

Restore install-folder (--prefix) choice in the dash onboarding wizard

Open
#75 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
40
Forks
9
Avg merge
4d 20h
Merged PRs (30d)
59

Description

Context

PR #67 retires the legacy tui.rs and routes rocm bootstrap setup to the dash onboarding wizard. The legacy interactive setup let users pick the TheRock/ROCm install location (surfaced on the CLI as --prefix PATH). The current dash onboarding wizard has no install-folder picker, so the guided bootstrap setup flow installs to the default location only.

This was deferred, not removed by design — tracked here so it isn't lost.

Scope

  • Add an install-location step to the onboarding wizard (crates/rocm-dash-tui/src/ui/onboarding.rs), feeding the existing --prefix plumbing (install_manager.rs already threads --prefix, and the chat tool path still supports it).
  • Decide the default and let the user override it, consistent with the pre-retirement behavior.

Notes

  • The Release/Nightly channel toggle — dropped in the same retirement — was already restored separately in #73, so this issue is scoped to the install-folder choice only.
  • rocm bootstrap setup's non-interactive fallback message was updated in #67 to stop advertising a folder picker; revert/adjust that wording once the picker returns.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in crates/rocm-dash-tui/src/ui/onboarding.rs and trace how install_manager.rs threads the existing --prefix option; compare with the pre-retirement behavior in tui.rs. Restore a default install location with a user override in the wizard, and adjust the non-interactive fallback wording so it accurately describes the returned picker.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.