ROCm / ROCm/rocm-cli

rocm comfyui status/install print different 'folder:' values; neither is the ComfyUI source folder

Open
#391 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
40
Forks
9
Avg merge
4d 20h
Merged PRs (30d)
59

Description

Current behavior

rocm comfyui install and rocm comfyui status both print a folder: line, but with different meanings, and neither is the ComfyUI source folder:

command folder: value source
rocm comfyui install <env>/apps/comfyui (app_root) apps/rocm/src/comfyui.rs:287
rocm comfyui status <env> (manifest.runtime_root) apps/rocm/src/comfyui.rs:135
actual ComfyUI checkout <env>/apps/comfyui/source (manifest.source_path)

Observed output on a6fa76dbca5d767c1190ee47b765d16bad0e4a53 (current main):

$ rocm comfyui install --runtime-id <key>
ComfyUI
  action: install
  ROCm install: 10.1.0a20260822 (build 2026-08-22)
  folder: ~/.rocm/envs/therock-10.1.0a20260822/apps/comfyui
  models path: ~/.rocm/envs/therock-10.1.0a20260822/apps/comfyui/source/models

$ rocm comfyui status
ComfyUI

  installed: yes
  ROCm install: 10.1.0a20260822 (build 2026-08-22)
  folder: ~/.rocm/envs/therock-10.1.0a20260822
  models path: ~/.rocm/envs/therock-10.1.0a20260822/apps/comfyui/source/models

Expected behavior

folder: should mean the same thing in both commands. Since models path: is already printed separately, the useful value for folder: is the ComfyUI source folder (manifest.source_path, the directory containing main.py), or the key should be renamed to make the distinction explicit (e.g. app folder: / ROCm install folder:).

Steps to reproduce

rocm comfyui install --runtime-id <active runtime key>
rocm comfyui status

Compare the two folder: lines.

Possible solution

Print manifest.source_path as folder: in both status (line 135) and install (line 287), and keep models path: as is. The repo's own harness scripts/comfyui_therock_gpu_test.py parses folder: and derives <folder>/models/checkpoints from it, which is wrong for both current values (#390); making folder: the source path would also make that derivation correct.

Your environment

  • rocm-cli channel: nightly (TheRock 10.1.0a20260822, gfx120X-all)
  • rocm-cli version (rocm --version): rocm 0.1.0, built from a6fa76dbca5d767c1190ee47b765d16bad0e4a53
  • Platform: Linux
  • OS / Distro: CachyOS (Arch), kernel 7.2
  • GPU/APU: AMD Radeon AI PRO R9700 (gfx1201)

Additional context

Low severity on its own; it matters because tooling (the in-repo GPU harness) keys off the line. User-visible output change, so per AGENTS.md it would want a Gherkin scenario update if the wording changes.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in apps/rocm/src/comfyui.rs at the status and install output locations cited in the issue, then inspect scripts/comfyui_therock_gpu_test.py and the relevant AGENTS.md guidance. Reproduce both commands, make the folder output consistent with the stated expected meaning, and update the Gherkin scenario if the user-visible wording changes. Verify that the harness derives the intended models path.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, rust
Domain
cli, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
76/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.