Free-space preflight does not cover the default `--format wheel` install path
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 40
- Forks
- 9
- Avg merge
- 4d 20h
- Merged PRs (30d)
- 59
Description
rocm install sdk defaults to --format wheel, but the free-space preflight added in #171 only covers the tarball path.
install_wheel_runtime delegates the download to uv pip install, which fetches the ROCm wheels plus PyTorch, torchvision and torchaudio — in aggregate the larger of the two install paths. Nothing there checks free space beforehand, and nothing maps an out-of-space failure to a readable message, so a user on a nearly-full disk still gets a raw error partway through. That is the symptom #159 asked to eliminate, on the path most users take.
The tarball path could be handled with a Content-Length probe because it is a single known artifact. The wheel path has no equivalent cheap signal: the set of wheels and their sizes are only known after uv resolves the dependency graph, so a preflight needs either a resolve-only pass to sum the wheel sizes, or a fixed conservative floor for a known-heavy install, or a post-hoc mapping of uv's out-of-space output. Those are different enough from the tarball approach to be worth deciding separately rather than bolting onto #171.
Scoped out of #171 for that reason; #171 is "Refs #159" rather than "Fixes #159" as a result.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the install_wheel_runtime entry point and compare it with the tarball preflight added in #171. Investigate how uv pip install resolves the ROCm, PyTorch, torchvision, and torchaudio wheels and reports out-of-space failures. Done means choosing one of the stated preflight or error-mapping strategies and covering the default wheel install path with a readable failure result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- pytorch, rust
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100