ROCm / ROCm/rocCV

[Feature] Adaptive vs Hard Limit on Int32

Open
#185 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
1
Forks
10
Avg merge
3d 1h
Merged PRs (30d)
1

Description

With PR #167, now use int32 instead of int64 for image wrapper indexing. Currently, all the operators enforce this as a hard limit via the CHECK_TENSOR_INT32_INDEXING validation check, except for CvtColor, which will use int64 indexing if the tensor is too large for int32:

    // line 176 src/op_cvt_color.cpp
    if (needsInt64Wrapper(input) || needsInt64Wrapper(output)) {
        dispatch_cvt_color_itype<int64_t>(stream, input, output, conversionCode, device);
    } else {
        dispatch_cvt_color_itype<int32_t>(stream, input, output, conversionCode, device);
    }

Should figure out in the future whether (some/all) operators should be made adaptive too, or if this limit should be enforced for performance/simplicity.

May also want to document this limit somewhere.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading PR #167 and tracing the CHECK_TENSOR_INT32_INDEXING validation across the operators. Compare those paths with the adaptive dispatch in src/op_cvt_color.cpp around line 176. Done means the project has an agreed policy for adaptive versus hard limits and the relevant behavior or documentation reflects that decision.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-vision
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.