ROCm / ROCm/aorta

Waitcheck GEMM: resolve each hipBLASLt solution to its real object/index/entry (no fabricated copies)

Open
#331 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
11
Forks
7
Avg merge
1d 17h
Merged PRs (30d)
31

Description

Follow-up from the PR #324 review (BLOCKER: "Whole-object scans are presented as selected GEMM checks").

scripts/sanitizers/prepare_gemm_isa.py currently copies one unbundled code object under every sol_<idx>.hsaco filename, so distinct hipBLASLt solutions are fabricated as identical objects. Waitcheck then scans the whole object.

Already landed in PR #324 (safe, in-repo parts):

  • Waitcheck no longer attributes object-scan findings to a synthetic GEMM kernel name (kernel_name=None for scan identities).
  • Identical scan identities now produce a single object-level invocation (dedup by code object).

Remaining (needs real hardware + hipBLASLt metadata):

  • Resolve each selected solution to its real code object, image index, and kernel entry offset so kernel-scoped Waitcheck can run exact-entry per solution.
  • Introduce an explicit object-scope result shape (no kernel identity/name) for the genuine whole-object-scan fallback, instead of reusing a kernel-named identity.
  • Update prepare_gemm_isa.py to stop emitting fabricated per-solution copies.

Test: identical scan identities must produce one object-level invocation and no fabricated kernel attribution (unit test landed); add hardware coverage for real per-solution exact-entry resolution.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with scripts/sanitizers/prepare_gemm_isa.py and the Waitcheck changes from PR #324. Trace how selected hipBLASLt solutions currently map to sol_.hsaco, then use the available metadata and real hardware to resolve each solution's code object, image index, and kernel entry offset. Done means exact-entry checks use real per-solution objects, genuine whole-object scans have an explicit object-scope result, and fabricated copies are no longer emitted.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
performance, testing, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.