ROCm / ROCm/Quartz

Add branch-name-check before writing status.json

Open
#64 0 comments 0 reactions 1 assignee View on GitHub

@HereThereBeDragons is already working on this.

Since Sep 8, 2026.

Dominant language
Python
Stars
1
Forks
1
Avg merge
3d 11h
Merged PRs (30d)
16

Description

Right now, the creation of status.json is only based on the repo and release_type.

It would be good to also add a check for the branch name (head_branch) to make sure that not nightly/prerelease is accidentally triggered from a user branch.

could be simple like "main" or startsWith("release/therock-") or could be more sophisticated to make sure that prereleases must be from release branches and nightly only from main.

function where the changes need to occure:
scripts/receive_therock/therock_update_status_json.py:update_status_json()

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.