Download timeout
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.9k
- Forks
- 152
- Avg merge
- 4h 14m
- Merged PRs (30d)
- 11
Description
I am at a very slow internet connection and downloading almost any model gives me a timeout:
[FLM] Downloading 2/7: model.q4nx
[FLM] Downloading: 86.0% (3830.0MB / 4455.4MB)CURL error: Timeout was reached
Currently there is a hard-coded timeout of one hour set here
I suggest removing this limitation, I think this can be done to setting the limit to 0, alternatively you could make it configurable.
Edit: Just as a reference, a 10Mbit connection can download just over 4 GB/h and a 4B sized model is just around that limit.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/pull/download_model.cpp:160 and inspect how the download request configures its one-hour timeout. Determine whether the timeout should be removed or made configurable, then verify that a model download can continue beyond one hour without failing due to the hard-coded limit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 74/100