Reduce congitive complexity in rewrite_rnn
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 333
- Forks
- 150
- Avg merge
- 4d 19h
- Merged PRs (30d)
- 54
Description
In clang tidy(from rocm 4.1), there is a warning about the functions in rewrite_rnn that exceed the cognitive complexity. There is description of how the congnitive complexity is caclulated here.
For now, I will suppress the warnings, but this should be fixed so we don't need to suppress the error.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the rewrite_rnn implementation and the functions reported by clang-tidy's readability-function-cognitive-complexity check. Read the linked clang-tidy guidance and inspect the existing warning suppressions; the work is done when the cognitive-complexity warnings no longer require suppression and the relevant tests still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- machine-learning
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100