Explore and determine if concat_reshape matcher can use non zero axis
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 333
- Forks
- 150
- Avg merge
- 4d 19h
- Merged PRs (30d)
- 54
Description
DOR (Definition of Ready)
Based on the review comments from - https://github.com/ROCm/AMDMIGraphX/pull/4984
Determine if this can be done when axis != 0.
Description
Determine and then impliment the extension to the concat_reshape matcher for non zero axis
DOD (Definition of Done)
If we can infact use axis=0 improve the matcher to be more general and use a non zero axis.
Else -> do nothing -> done is we explored the path.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the review comments in pull request #4984 and locate the concat_reshape matcher implementation. Determine whether matching remains valid when axis is non-zero, then verify the relevant matcher behavior. Done means either extending the matcher to support non-zero axes or confirming that no change should be made.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- machine-learning
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100