[Issue]: gfx_default_rocblas used without checking MIGRAPHX_USE_HIPBLASLT
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 333
- Forks
- 150
- Avg merge
- 4d 19h
- Merged PRs (30d)
- 54
Description
Problem Description
When the cmake variable MIGRAPHX_USE_HIPBLASLT is OFF, there is this compile error
/src/targets/gpu/lowering.cpp:267:51: error: no member named 'gfx_default_rocblas' in namespace 'migraphx::gpu'
267 | not hipblaslt_supported() or gpu::gfx_default_rocblas()))
The failure happens because gfx_default_rocblas is conditionally defined here
Operating System
Fedora Rawhide
CPU
ALL
GPU
AMD Instinct MI300
Other
No response
ROCm Version
ROCm 6.0.0
Steps to Reproduce
ROCm version is really 7.0.1
(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support
No response
Additional Information
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the failing reference at src/targets/gpu/lowering.cpp:267 and compare it with the conditional definition in src/targets/gpu/include/migraphx/gpu/device_name.hpp:48. Reproduce the build with MIGRAPHX_USE_HIPBLASLT set to OFF, then verify that the project compiles successfully in that configuration without breaking the enabled configuration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100