ROCm / ROCm/AMDMIGraphX

Pooling Improvements

Open
#3,367 0 comments 0 reactions 1 assignee View on GitHub

@pfultz2 is already working on this.

Since Aug 12, 2024.

Dominant language
C++
Stars
333
Forks
150
Avg merge
4d 19h
Merged PRs (30d)
54

Description

Problems with "rewrite_pooling" pass.

  • It doesn't handle LpPool case with dilation. Link1
  • it is doing gather on original input and not on the padded one. Link2
  • It doesn't handle pre and post padding. Link3

ONNX backend tests that are affected :

    backend_test.exclude(
        r'test_averagepool_3d_dilations_large_count_include_pad_is_0_ceil_mode_is_True_cpu'
    )
    backend_test.exclude(
        r'test_averagepool_3d_dilations_large_count_include_pad_is_1_ceil_mode_is_True_cpu'
    )
    backend_test.exclude(r'test_maxpool_2d_ceil_output_size_reduce_by_one_cpu')
    backend_test.exclude(r'test_maxpool_3d_dilations_use_ref_impl_large_cpu')

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.