ROCm / ROCm/AMDMIGraphX

Better handling of corrupt or invalid onnx files

Open
#3,001 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
333
Forks
150
Avg merge
4d 19h
Merged PRs (30d)
54

Description

Currently if an onnx file is empty (i.e., contains 0 bytes), MIGraphX will throw a segfault. This is not a useful message to the user. We should try to have some way of first checking if the onnx file (or protobuf) is valid.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how MIGraphX loads and parses ONNX files and protobuf data, focusing on the empty-file path described in the issue. Done means empty or invalid input no longer causes a segmentation fault and instead produces a useful error message.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
machine-learning
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.