ROCm / ROCm/AMDMIGraphX

GEMM -> pointwise (GELU) -> GEMM fusion

Open
#2,819 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Perf Improve Tier1
Dominant language
C++
Stars
333
Forks
150
Avg merge
4d 19h
Merged PRs (30d)
54

Description

From the 22 Feb 2024 performance model review of Distilgpt2:

what Paul had suggested but it can go further because pointwise is also used once.
e.g. pointwise kernel @55 here is only used for @57.

therefore it can be gemm+pointwise+gemm fusion

@50 = gpu::code_object[code_object=6584,symbol_name=mlir_reshape_dot,global=36864,local=256,](@44,@48,@49) -> half_type, {348, 3072}, {3072, 1}, target_id=0: 0.0281931ms, 2%
@51 = reshape_lazy[dims={1, 348, 3072}](@50) -> half_type, {1, 348, 3072}, {1069056, 3072, 1}, target_id=0: 0.00051212ms, 1%
@52 = multibroadcast[out_lens={348, 3072},out_dyn_dims={}](@47) -> half_type, {348, 3072}, {0, 1}, target_id=0: 0.00054692ms, 1%
@53 = reshape_lazy[dims={1, 348, 3072}](@52) -> half_type, {1, 348, 3072}, {0, 0, 1}, target_id=0: 0.00049298ms, 1%
@54 = load[offset=1069056,end=3207168](@1) -> half_type, {1, 348, 3072}, {1069056, 3072, 1}, target_id=0: 0.00038882ms, 1%
@55 = gpu::code_object[code_object=5136,symbol_name=add_mul_mul_mul_mul_add_neg_sub_exp_add_div_mul_kernel,global=534528,local=1024,](@51,@53,@54) -> half_type, {1, 348, 3072}, {1069056, 3072, 1}, target_id=0: 0.0134347ms, 1%
@56 = load[offset=3207168,end=3741696](@1) -> half_type, {348, 768}, {768, 1}, target_id=0: 0.00054628ms, 1%
@57 = gpu::code_object[code_object=5240,symbol_name=mlir_reshape_dot,global=67584,local=256,](@55,@46,@56) -> half_type, {348, 768}, {768, 1}, target_id=0: 0.0325462ms, 3%
  • Possible to fuse with MLIR with split_k. Might not be a performance improvement however with how the k dimension (3072) compares to the row dimension (348).

Deliverables:

  • Will have to communicate with MLIR if this fusion would be better and if it would be supported
  • If it can be better do the fusion

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the @50–@57 graph sequence and investigate whether MLIR supports GEMM → pointwise GELU → GEMM fusion with split_k. Compare the fused and unfused performance for the Distilgpt2 shape, then confirm with MLIR whether the fusion is beneficial and supported; implement it only if both conditions hold.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers, machine-learning, performance
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.