ROCm / ROCm/AMDMIGraphX

Fuse `gather` and `pointwise`

Open
#2,814 0 comments 0 reactions 1 assignee View on GitHub

@pfultz2 is already working on this.

Since Apr 23, 2025.

Perf Improve Tier1
Dominant language
C++
Stars
333
Forks
150
Avg merge
4d 19h
Merged PRs (30d)
54

Description

From the 22 Feb 2024 performance model review of Distilgpt2:

Although it might be minor, we could fuse a pointwise with gather so we can get rid of the extra add_kernel:

@8 = gpu::code_object[code_object=9224,symbol_name=gather_kernel,global=225280,local=1024,](@6,@5,@7) -> half_type, {1, 348, 768}, {267264, 768, 1}
@9 = load[offset=0,end=534528](@1) -> half_type, {1, 348, 768}, {267264, 768, 1}
@10 = gpu::code_object[code_object=9088,symbol_name=add_kernel,global=133632,local=1024,](@8,@2,@9) -> half_type, {1, 348, 768}, {267264, 768, 1}

We would need to extend the gather kernel to also do the pointwise operation. Not sure if this fusion would lead to a performance improvement or possibly make the performance worse.

Delieverables:

  • Investigate whether fusing pointwise kernels with gather would improve performance
  • If we can improve performance with the fusion, implement the fusion

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.