ROCm / ROCm/AMDMIGraphX

Update `pass_manager` to handle updating the cached shape when submodule shapes change

Open
#2,744 0 comments 0 reactions 1 assignee View on GitHub

@kahmed10 is already working on this.

Since Aug 6, 2025.

Cleanup enhancement
Dominant language
C++
Stars
333
Forks
150
Avg merge
4d 19h
Merged PRs (30d)
54

Description

  • Extend code in pass_manager.cpp:run_passes(prog, root_mod, passes, trace) to handle updating the cached shape from op.compute_shape(shape_inputs, mod_inputs) when mod_inputs shape changes.
    • Currently, the cached shape is not updated when submodule inputs have their output shape changed.
    • Can probably be implemented by keeping track of the parent instructions that need to be updated after all submodules are updated.
  • Remove the simplify_select_module_output_shape matcher and pass from simplify_dyn_ops.cpp. Move the shape computation logic into select_module.compute_shape().

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.