Update compiler pass unit tests to also verify the replacement gets the same result
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- C++
- Stars
- 333
- Forks
- 150
- Avg merge
- 4d 19h
- Merged PRs (30d)
- 54
Description
- Tests like
test/rewrite_gelu_test.cppreplace significant blocks of a model. - We currently check that the replacement proceeds as expected, but not if the replacement gets the same result as the original code
- Our unit tests could be improved by executing the before and after code with random data and making sure the results are the same.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the compiler pass tests in test/rewrite_gelu_test.cpp and review how they verify that replacements proceed as expected. Execute the original and replacement code with random data, then make the tests compare their results so equivalent behavior is verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100