Use hipHostFree to free up allocated memory on Host
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 333
- Forks
- 150
- Avg merge
- 4d 19h
- Merged PRs (30d)
- 54
Description
This issue came up from #1245
Migraphx is using hipHostMalloc to allocate memory on host when there isn't enough memory on GPU or when hip::copy_from_gpu is invoked without destination argument.
hipHostMalloc resource is controlled by unique_ptr with hipFree deleter, which should be hipHostFree.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the hipHostMalloc calls and the unique_ptr using the hipFree deleter, including the hip::copy_from_gpu path mentioned in the issue. Replace the mismatched deallocation choice with hipHostFree and verify that host allocations from both described paths are released correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- performance
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100