BotManager can fail to call retire
Open
Nobody has claimed this yet.
bug
- Dominant language
- Java
- Stars
- 1
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
The BotManager can fail to call bots' retire method since the bot loop keeps waiting for a game tick data that never arrives.
I don't know if this happens in practice, but it looks possible from the code.
The BotManager should probably wait for all threads to join before returning from retire.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate BotManager and trace the retire path, the bot loop, and its wait for game tick data. Verify the behavior when no tick arrives, and consider completion to mean that every bot's retire method has been called and all related threads have joined before retire returns.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100