REditorSupport / REditorSupport/vscode-R

Refactor `any` values to typed object

Open
#478 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

engineering
Dominant language
TypeScript
Stars
1.2k
Forks
139
Avg merge
2h 46m
Merged PRs (30d)
5

Description

Extends from #474

Currently, we disabled many eslint for the new implementation file due to the any value problem.
It can be object value by like the following link
Related rule link: https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-unsafe-assignment.md

Target files

  • extension.ts
  • rHelpPanel.ts
  • RHelpProviderBuiltin.ts
  • rstudioapi.ts
  • session.ts
  • test/suite/index.ts

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the disabled ESLint rules and the no-unsafe-assignment rule linked in the issue, then inspect extension.ts, rHelpPanel.ts, RHelpProviderBuiltin.ts, rstudioapi.ts, session.ts, and test/suite/index.ts. Replace the problematic any values with typed objects across the listed files and verify that the relevant ESLint checks can be enabled without errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
eslint, typescript
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.