REditorSupport / REditorSupport/vscode-R

Changes to Textmate scopes

Open
#1,601 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
1.2k
Forks
139
Avg merge
2h 46m
Merged PRs (30d)
5

Description

Describe the bug
With v2.8.5, textmate scopes have changed and many tokens only have the 'source.r' scope (related to Rsyntax upgrade?). As a result, themes and customisation are affected with limited ability to fine tune.

To Reproduce

  1. Before upgrading to 2.8.5, observe that object on the left hand side of <- (e.g. dt <- data.table()) have two textmate scopes - variable.other.r and source.r
  2. Upgrade to 2.8.5
  3. Only 1 textmate scope left - source.r

Can you fix this issue by yourself? (We appreciate the help)

Yes / [No]

Expected behavior
Behaviour prior to upgrade where tokens have multiple textmate scope to fine tune customisation.

Environment (please complete the following information):

  • OS: macOS
  • VSCode Version: 1.99.2
  • R Version: 4.4.2
  • vscode-R version: 2.8.5

Thanks

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the scope difference using vscode-R 2.8.5 with the reported R example, comparing it with the behavior before the upgrade. Trace the TextMate scope generation or Rsyntax upgrade path responsible for the change. Done means tokens such as the object left of <- regain the expected variable.other.r and source.r scopes, with theme customization restored.

Written by the indexing model from the issue text.

Assessment

Tech stack
r, typescript, vscode
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.