REditorSupport / REditorSupport/vscode-R
vscode version constraint may need bumping
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.2k
- Forks
- 139
- Avg merge
- 2h 46m
- Merged PRs (30d)
- 5
Description
When using older versions of vscode (particularly vscode server in posit workbench) - we see that the extension on startup fails with version constraint
The last 2 posit workbench versions are both on 1.79.
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
install the REditorSupport extension
Open the developer tools and see the error in the console
Can you fix this issue by yourself? (We appreciate the help)
Uncertain - is it as easy as bumping https://github.com/REditorSupport/vscode-R/blob/master/package.json#L29 to a more recent version?
If it was possible to know which 1.82 api's were introduced with the new release, I may be able to help figure out/test backwards compat. We discovered this with one quarto extension that accidentally introduced the use of a new api and broke similarly, and wrapped it in a conditional to get around it.
Expected behavior
Extension starts up cleanly
Screenshots
Screenshots attached above
Environment (please complete the following information):
- OS: Linux, Ubuntu 22.04
- VSCode Version: [e.g. 1.79.2]
- R Version: N/A
- vscode-R version: 2.8.2
Additional context
Downgrading back to 2.8.1 manually works and the extension (unsurprisingly) works fine for that version since it was released prior to 1.82.
Its worth noting that the marketplace/vscode does suitably filter the version - for example, extensions that have newer versions that rely on more recent versions of vscode will fallback to older version - so the user outcome with proper bounds would be the most recent version for people on new version(s), and 2.8.1 for the older versions.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with package.json line 29 and inspect the extension's VS Code version constraint. Compare the APIs introduced around VS Code 1.82 with support for the reported 1.79 environment, then verify that the extension starts cleanly on both versions. Done means older compatible installations receive a working extension without unnecessarily excluding newer VS Code releases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100