REditorSupport / REditorSupport/vscode-R
Useless `"patterns"` array
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.2k
- Forks
- 139
- Avg merge
- 2h 46m
- Merged PRs (30d)
- 5
Description
"patterns": [ { "include": "#lambda-functions" } ] does not work with the "match" rule
it currently doesn't do anything and can be safely removed
https://github.com/REditorSupport/vscode-R/blob/ce8ae9c31e08c38471aac861a2207fe3716776fe/syntax/r.json#L456
Two random "name" rules that don't do anything
can be safely removed
https://github.com/REditorSupport/vscode-R/blob/ce8ae9c31e08c38471aac861a2207fe3716776fe/syntax/r.json#L536
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open syntax/r.json around lines 456 and 536 and inspect the referenced "patterns" and "name" rules. Remove the entries that do not affect the match rule or syntax behavior, then review the surrounding JSON to confirm the file remains valid and the useless rules are gone.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100