R2NorthstarTools / R2NorthstarTools/FlightCore
Improve control flow for detecting EA App install path
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 94
- Forks
- 20
- PR merge metrics
- No merged PRs in 30d
Description
Originally posted by @Jan200101 in https://github.com/R2NorthstarTools/FlightCore/pull/394#discussion_r1241218353
the type that
get_valuereturns depend on the type that is expected, so we cannot easily set the type of game_path_str to something likeResult<String>without the function returning aResult<Result<String>>.The curent way its done is a bit ugly but it does the job (plus what are the chances someone has the registry subkey but not the value :clueless:)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue does not name a file or test. Locate the EA App install-path detection and inspect how get_value and the registry subkey/value cases are handled; done means the control flow is improved without changing the detected path behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- desktop, operating-systems
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100