QwikDev / QwikDev/qwik

[🐞] [v2] enabling SSG in the dev-server stops images from emitting

Open
#7,754 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug router
Dominant language
TypeScript
Stars
22.1k
Forks
1.4k
Avg merge
1d 10h
Merged PRs (30d)
52

Description

Which component is affected?

Qwik Runtime

Describe the bug

When adding the node adapter to the starters testing dev-server, the frontpage image tests fail, because the images generated by vite-imagetools are no longer under dist/assets

Reproduction

https://github.com/QwikDev/qwik/blob/aad9ef68913a8db3e939b121cb6bcae8ee205c8f/starters/dev-server.ts#L153-L172

Steps to reproduce

uncomment the lines and run pnpm serve, then go to the qwikrouter-test and notice the broken images.

Not sure if this happens in v1 as well.

System Info
v2
Additional Information

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in starters/dev-server.ts around lines 153-172 and uncomment the node-adapter lines. Run pnpm serve, then inspect qwikrouter-test and the frontpage image tests to reproduce the missing-image behavior. Done means images generated by vite-imagetools are emitted under dist/assets and the affected tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
nodejs, typescript, vite
Domain
build-system, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.