QwenLM / QwenLM/qwen-code

Deferred review findings from PR #11395: fix(acp): preserve caller-owned mode after child reap

Open
#11,637 0 comments 0 reactions 1 assignee View on GitHub

@qqqys is already working on this.

Since Sep 11, 2026.

Dominant language
TypeScript
Stars
28k
Forks
3.1k
Avg merge
1d 2h
Merged PRs (30d)
714

Description

Verified review findings from PR #11395 by qqqys whose fixes lie outside that PR's footprint, deferred by the autofix loop for follow-up. cc @qqqys. Each rc: item links back to its original review comment. A maintainer or the PR author can turn any item into its own issue/PR and apply the ready-for-agent flow to that issue — nothing here is scheduled automatically.

  • rc:3972173759 packages/acp-bridge/src/bridge.ts: Verified real: the attach-time snapshot corrections spread the pre-apply modes object, so a stale modes._meta.planExecutionMode survives a correction that moves the session out of plan. Deferred under the round-5+ convergence posture: the fix changes the response payload shape at three correction sites and needs its own witness cycle. — comment
  • rc:3972173785 packages/acp-bridge/src/bridge.ts: Verified real: the coalesced-waiter twin of the live-attach snapshot correction has no test distinguishing its two operands (deleting the block leaves the suite green). Deferred: the witness needs the coalesced-restore harness, more setup than fits in this Critical-focused round. — comment
  • rc:3972173801 packages/cli/src/serve/server.test.ts: Verified real: no test asserts the load/resume routes forward approvalMode to the bridge. Deferred under the round-5+ convergence posture; pure test addition, no production change needed. — comment

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.