Deferred review findings from PR #10317
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 28k
- Forks
- 3.1k
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 714
Description
Verified review findings from PR #10317 whose fixes lie outside that PR's footprint, deferred by the autofix loop for follow-up. A maintainer can turn any item into its own issue/PR (or apply the ready-for-agent flow) — nothing here is scheduled automatically.
- rc:3874248945
packages/cli/src/ui/utils/goal-runtime.ts: Verified real: Config.getGoalRuntimeReady() (packages/core/src/config/config.ts:8462) throws GoalPersistenceUnavailableError synchronously via getGoalRuntime() when chat recording is disabled, while goal-protocol.ts:224 documents a rejection; getGoalRuntimePrepared() shares the shape. The async-normalization fix belongs in packages/core, outside this CLI PR's footprint, so it is deferred to the follow-up queue.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/cli/src/ui/utils/goal-runtime.ts and the referenced packages/core/src/config/config.ts:8462 and goal-protocol.ts:224. Trace the synchronous GoalPersistenceUnavailableError path and compare it with the documented rejection behavior, including getGoalRuntimePrepared(); done means the core follow-up consistently matches the documented async contract.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend-api-design, cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100