Quenty / Quenty/NevermoreEngine

DataStoreStage::StoreOnValueChange throws if ValueBase set to 'nil'

Open
#471 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
610
Forks
144
Avg merge
1d 20h
Merged PRs (30d)
12

Description

It calls an internal method that doesn't replace nil with DataStoreDeleteToken. Chaos ensues!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating DataStoreStage::StoreOnValueChange and the internal method it calls. Verify the nil-to-DataStoreDeleteToken behavior and add or update a regression test showing that setting ValueBase to nil no longer throws.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
database, game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.