Quenty / Quenty/NevermoreEngine
Cannot Stop sounds created on client with SoundUtils
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 610
- Forks
- 144
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 12
Description
You cannot stop sounds created on the client with SoundUtils. This is as it uses DataModel:GetService("SoundService"):PlayLocalSound to play sounds locally. If the end user were to destroy the sound while it was still playing, it'd still play and this is especially annoying for use-cases such as doors or tools.
Another pet-peeve is that task.delay continues to run even if the sound is destroyed. Check if the sound is destroyed so you're not calling a nil value!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating SoundUtils and its use of DataModel:GetService("SoundService"):PlayLocalSound, then inspect the task.delay callback. Verify how locally played sounds can be stopped when their source is destroyed, and ensure delayed work does not call a destroyed sound; done means both cases are handled without errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100