QuantumBadger / QuantumBadger/RedReader
Floating Toolbar Buttons / Navigation Arrows Layout - Needs Separate Menu Option
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 2.7k
- Forks
- 527
- Avg merge
- 20d 10h
- Merged PRs (30d)
- 3
Description
Issue raised off the back of this Reddit thread.
With the release of 1.25, there was a behaviour change related to the navigation arrows / floating toolbar buttons that display near the bottom of the screen when viewing comments.
Previous to the release of 1.25, it was possible was possible to have the app set up in the following way:
- When browsing a subreddit, all thumbnails are on the right-hand side of the screen.
- When browsing comments, the navigation arrows are on the right-hand side of the screen.
V1.25 has changed this behaviour - I believe the change happened in this pull request - https://github.com/QuantumBadger/RedReader/pull/1208/files .
Both of these UI elements are now linked to the menu item "Left-handed mode".
This is set up so that the thumbnails and navigation arrows will always be on opposite sides of the screen - i.e. it is impossible to recreate my old layout of having both options on the right.
Please could we get a new menu item which sets the position of the navigation buttons, and separates it from the "Left-handed mode" setting?
There is an existing setting "Show navigation buttons over comments" - a new setting underneath this which swaps the navigation buttons to the other side would be perfect.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing pull request #1208 and locating the existing "Left-handed mode" and "Show navigation buttons over comments" settings. The work is done when navigation-button placement can be configured independently, allowing both thumbnails and navigation arrows on the right.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100