QuantumBadger / QuantumBadger/RedReader
Displayed domain on certain posts is incorrect
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 2.7k
- Forks
- 527
- Avg merge
- 20d 10h
- Merged PRs (30d)
- 3
Description
On certain posts, the displayed domain in parentheses is reddit.com even when Post Properties has a URL with a different domain.
Based on a sample of size two, this seems to be the case for posts that Old Reddit (on a web browser) is able to display as an embedded album (via preview.redd.it), but which are actually linked to an external (non-Reddit) domain.
It should be noted that Old Reddit also incorrectly shows reddit.com in these cases. If indeed it is the Reddit API that is supplying an incorrect domain, then it would be good if RedReader does its own parsing to determine the correct domain based on the actual link URL. (The goal is to avoid unexpected redirection to facebook.com, for example.)
Examples:
| Post link | RedReader post screenshot | RedReader properties screenshot | Old Reddit screenshot |
|---|---|---|---|
| 103iu5b | |||
| 192tk1z |
Above RedReader screenshots are for RedReader v1.22, and the observed behaviour persists to v1.23.1.
Related post (not mine, but led me to the 103iu5b example): https://www.reddit.com/r/RedReader/comments/103wk4j/wrong_domain_showing/
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the incorrect domain using the linked Reddit posts 103iu5b and 192tk1z, then trace the post display and Post Properties entry points that consume the URL. Compare the displayed domain with the external link's actual host; done means both examples show the correct domain and do not suggest an incorrect redirection target.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100