QuantumBadger / QuantumBadger/RedReader
[feature request] Be more forgiving about parsing spoiler tags.
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 2.7k
- Forks
- 527
- Avg merge
- 20d 10h
- Merged PRs (30d)
- 3
Description
I constantly stumble across spoilers in redreader that aren't masked because redreader won't process the spoiler tags because of spaces.
Example:
The following is not successfully hidden behind a spoiler box.
>! One two three. !<
The below is hidden behind a spoiler box.
>!one two three. !<
As other clients (including new.reddit.com) do hide spoiler tags regardless of spacing it means users are nonthewiser and leave them, and only us redreader users are spoiled.
It's been this way for years, and has bitten me many times. Probably time to improve it.
Example comment
https://reddit.com/comments/16pvguf/comment/k20cw4y?context=3
(Funnily enough old.reader.com also processes spoilers the way redreader does. Whilst new.reddit.com parses them regardless of space, typical Reddit being inconsistent)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating RedReader's spoiler-tag parsing entry point and reproduce the two examples from the issue, including spaces after the opening marker. Check the linked Reddit comment for the reported case. Done means spoiler tags are hidden consistently regardless of the spacing shown, without changing the existing no-space behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100