Quantco / Quantco/tabmat

Is there a preference for memory order (`C` or `F`) in tabmat?

Open
#392 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
Python
Stars
140
Forks
10
Avg merge
18h 17m
Merged PRs (30d)
2

Description

Followup to https://github.com/Quantco/glum/issues/838. In particular, I'd like to avoid any unnecessary copies when creating a

data_continuous = tabmat.DenseMatrix(data[:, continuous_mask], column_names=column_names)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the DenseMatrix construction shown in the issue and read the follow-up discussion in Quantco/glum#838. Trace how the sliced data is handled with C- and F-order inputs, then define the preferred order and verify whether the construction avoids unnecessary copies.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data, performance
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.