Quantco / Quantco/spox

Tracking issue for full-feature inline

Open
#82 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
101
Forks
8
Avg merge
18h 53m
Merged PRs (30d)
5

Description

inline is currently missing:

  • Support for subgraphs (they should get prefixed properly, which ONNX renaming doesn't do)
  • Support for functions (such local/dependency functions should be propagated to the built model)
  • Capability not do add extraneous Identity nodes for all model input/outputs (requires better renaming capabilties)

Most of these can be fixed by reimplementing renaming values in graphs, as the ONNX feature (onnx.compose.add_prefix_graph) is rather lacking.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation of inline and the graph-renaming logic, then compare it with ONNX's onnx.compose.add_prefix_graph. Focus on the unchecked function-support item; done means local and dependency functions are propagated to the built model without regressing the completed subgraph and Identity-node behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.