Quantco / Quantco/polarify

Errors with a type checker

Open
#83 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
145
Forks
3
PR merge metrics
No merged PRs in 30d

Description

If you ever use a type checker, such as basedpyright, the polarify function will make lots of errors.

image

It's because pl.Expr type is not directly comparable. Removing the type will remove errors (as long as your project allows untyped functions.)

image

I wonder if there's any fix for this? Maybe when it's not typed, the output function is assumed to be pl.Expr?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported errors with basedpyright and inspect the polarify function, especially its handling of pl.Expr types. The work is done when the function's typing no longer produces the reported type-checker errors while preserving its existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.